Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#31202 closed defect (bug) (fixed)

Customizer preview iframe should have a title

Reported by: celloexpressions's profile celloexpressions Owned by: ocean90's profile ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: has-patch
Focuses: accessibility Cc:

Attachments (2)

31202.diff (470 bytes) - added by celloexpressions 9 years ago.
Add a title to the customize-preview iframe
31202.2.patch (4.1 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (9)

9 years ago

Add a title to the customize-preview iframe

#1 @westonruter
9 years ago

  • Keywords commit added
  • Owner set to ocean90
  • Status changed from new to reviewing

I was afraid that this change might have resulted in the tooltip appearing whenever you put your mouse over any part of the preview iframe, but this doesn't seem to be the case.

#2 @ocean90
9 years ago

I don't think that the container of the iframe should get the title, rather the iframe itself. See for plugin details iframe.

#3 @DrewAPicture
9 years ago

  • Keywords needs-patch added; has-patch commit removed

See comment:2

This ticket was mentioned in Slack in #core-customize by afercia. View the logs.

9 years ago

9 years ago

#5 @afercia
9 years ago

New patch tries to add a title attribute for:

  • main iframe (used just when the customizer overlays an admin page)
  • preview iframe
  • login iframe (shown in lieu of the preview iframe after session expiration)

Please check carefully, I'm not sure about a couple of things, one of them is:

iframe = $('<iframe src="' + self.previewUrl() + '" title="' + wp.customize.l10n.previewIframeTitle + '" />').hide();

why this way to select an already existing iframe? or maybe there are edge case conditions when the iframe needs to be created and suddenly hidden? Definitely don't have a deep knowledge of all the customizer code, but I'm a bit confused about that piece of code.

#6 @joedolson
9 years ago

  • Keywords has-patch added; needs-patch removed

#7 @ocean90
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 31704:

Customizer: Add title attributes to iframes.

props afercia.
fixes #31202.

Note: See TracTickets for help on using tickets.