WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#31213 closed defect (bug) (fixed)

oEmbed discovery fails on XML-encoded link URLs

Reported by: cweiske Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

Special characters like & in URLs should be encoded in HTML pages (& becomes &).

Wordpress' oEmbed discovery in WP_oEmbed::discover() does not decode the encoded entities and then tries to fetch URLs like

http://example.org/oembed.php?format=json&url=...

It should use htmlentities_decode() on the extracted URLs.

Attachments (1)

fix-31213.diff (833 bytes) - added by cweiske 6 years ago.

Download all attachments as: .zip

Change History (4)

@cweiske
6 years ago

#1 @cweiske
6 years ago

  • Keywords has-patch added

#2 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31413:

oEmbed discovery fails on encoded link URLs: decode HTML chars in the HTML-encoded URLs that are returned.

Props cweiske.
Fixes #31213.

#3 @wonderboymusic
6 years ago

  • Milestone changed from Awaiting Review to 4.2
Note: See TracTickets for help on using tickets.