WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#31217 closed enhancement (fixed)

Remove instances of generic "Dear user" message

Reported by: johnbillion Owned by: ipstenu
Milestone: 4.2 Priority: low
Severity: normal Version:
Component: Administration Keywords: good-first-bug has-patch needs-testing
Focuses: multisite Cc:

Description

Several of the email notifications which WordPress sends out include the greeting "Dear user", which is commonly associated with spam or phishing emails rather than legitimate emails.

Let's see if we can replace these instances with the user's display name, or remove the greeting altogether where we don't have any user information.

Good first bug for someone who wants to take it.

Attachments (6)

31217-ms-functions.diff (719 bytes) - added by Ipstenu 7 years ago.
31217-ms-delete-site.diff (1.3 KB) - added by Ipstenu 7 years ago.
With Username
31217-ms-delete-site-2.diff (800 bytes) - added by Ipstenu 7 years ago.
Without username
31217-schema.diff (425 bytes) - added by Ipstenu 7 years ago.
31217-ms.diff (2.2 KB) - added by Ipstenu 7 years ago.
31217.diff (5.0 KB) - added by Ipstenu 7 years ago.
Full patch, all changes

Download all attachments as: .zip

Change History (16)

#1 @SergeyBiryukov
7 years ago

  • Focuses multisite added

@Ipstenu
7 years ago

With Username

@Ipstenu
7 years ago

Without username

@Ipstenu
7 years ago

@Ipstenu
7 years ago

#2 follow-up: @Ipstenu
7 years ago

31217-ms-delete-site.diff and 31217-ms-delete-site-2.diff are basically one with and one without the username. The rest already had the logic in to pull in USERNAME or ###USERNAME### so I reused that and did a "Howdy USERNAME" to match the toolbar.

#3 @johnbillion
7 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#4 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.2

#5 @DrewAPicture
7 years ago

  • Owner set to ipstenu
  • Status changed from new to assigned

#6 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
7 years ago

Replying to Ipstenu:

31217-ms-delete-site.diff and 31217-ms-delete-site-2.diff are basically one with and one without the username.

31217-ms-delete-site.diff seems like the way to go.

Could you create a single patch with all the changes for easier review?

@Ipstenu
7 years ago

Full patch, all changes

#7 in reply to: ↑ 6 @Ipstenu
7 years ago

Replying to SergeyBiryukov:

Could you create a single patch with all the changes for easier review?

Done.

#8 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31403:

Replace generic "Dear user" greeting in email notifications with a more personalized one.

props Ipstenu.
fixes #31217.

#9 @SergeyBiryukov
7 years ago

In 31404:

Remove redundant string with a typo introduced in [25481].

see #31217.

#10 @ocean90
6 years ago

In 33569:

Multisite mails: Initialize $current_user before accessing $current_user->user_login.

props Toro_Unit.
see #31217.
fixes #33254.

Note: See TracTickets for help on using tickets.