WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31233, comment 27


Ignore:
Timestamp:
03/19/2015 10:23:33 PM (6 years ago)
Author:
valendesigns
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31233, comment 27

    initial v1  
    1 The latest patch [attachment:31233.11.diff] manually inserts the markup into the notice, which avoids any delay in rending the button. The JS will still automatically append the markup if it's missing from the notice so it can be used in other places in the future without having to manually add it. After some discussion on Slack we decided to switch to `slideUp` instead of `fadeOut` as the animation seemed a jarring.
     1The latest patch [attachment:31233.11.diff] manually inserts the markup into the notice, which avoids any delay in rending the button. The JS will still automatically append the markup if it's missing from the notice so it can be used in other places in the future without having to manually add it. After some discussion on Slack we decided to switch to `slideUp` instead of `fadeOut` as the animation seemed jarring.