WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31233, comment 30


Ignore:
Timestamp:
03/23/2015 05:33:40 PM (5 years ago)
Author:
paulwilde
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31233, comment 30

    initial v1  
    1 Using the class {{{.alert-dismiss}}}, or better yet {{{.alert-dismissable}}} would be better as it gives it context and conforms more with the classes which were introduced in [30505]. It also has the benefit of not being too generic so you can easily search through the entire code-base and know that all of the results refer to this functionality.
     1Using the class {{{.notice-dismiss}}}, or better yet {{{.notice-dismissable}}} would be better as it gives it context and conforms more with the classes which were introduced in [30505]. It also has the benefit of not being too generic so you can easily search through the entire code-base and know that all of the results refer to this functionality.
    22
    33All of the {{{.updated}}} and {{{.error}}} classes should eventually be updated to use the {{{.notice-*}}} classes inside the admin as well and just keep the CSS there for back-compact. I'll create a patch (for 4.3, as 4.2 is too far into beta I'm guessing?) at some point which does just that unless someone else wants to champion that.
    44
    5 Also another minor gripe, the classes used are overqualified they should simply just be {{{.alert-close}}} instead of {{{div.close}}}. then the CSS can be refactored to be {{{.alert-close}}} instead of {{{.wrap div.dismiss button.close}}}.
     5Also another minor gripe, the classes used are overqualified they should simply just be {{{.notice-close}}} instead of {{{div.close}}}. then the CSS can be refactored to be {{{.notice-close}}} instead of {{{.wrap div.dismiss button.close}}}.