WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31233, comment 52


Ignore:
Timestamp:
04/01/2015 10:01:12 PM (5 years ago)
Author:
helen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31233, comment 52

    initial v1  
    11@valendesigns: All looks really good, thanks. In doing final review, etc., I changed `.notice-close` to `.notice-dismiss` for consistency and defined the icon for that element rather than keeping the extra span. I also expanded the usage to other places in the admin, of which there were a lot. Most core notices will now have them, with the exception of a couple of errors. There may be some that don't really need to be dismissed, but it's not super intrusive so I'm going to roll with it as-is and we can selectively back stuff out later if something seems really egregious.
     2
     3Also, I removed the Mozilla hack as well, and defined the padding in px since the button is sized in px. I think there were rounding issues, as it looks good to me now. Again, we can pixel-poke after this commit.