WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#31239 closed defect (bug) (fixed)

Can't update captions in a gallery

Reported by: iseulde Owned by: helen
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Media Keywords: make-flow has-patch
Focuses: javascript Cc:

Description

See https://make.wordpress.org/flow/2015/02/05/caption-changes-are-not-reflected-in-the-editor-macnchrome-4-2-alpha-31332/

To reproduce, add a gallery without captions, click edit, add a caption to a photo, update and nothing changes. Updating the post will refresh the gallery and then the caption is visible.

Attachments (2)

31239.patch (646 bytes) - added by iseulde 7 years ago.
31239.2.patch (745 bytes) - added by iseulde 7 years ago.

Download all attachments as: .zip

Change History (8)

@iseulde
7 years ago

#1 @iseulde
7 years ago

  • Keywords has-patch added; needs-patch removed

#2 @iseulde
7 years ago

Explanation: the caption is not actually in the shortcode, it's tied to the ID. We check if the shortcode changes before updating, but updating a caption doesn't change the shortcode. Solution: always update.

@iseulde
7 years ago

#3 @helen
7 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 31343:

MCE views: Always refresh the view after updating a gallery.

This allows things like caption changes to be synced, as they are tied to the attachment and not the shortcode.

props iseulde.
fixes #31239.

This ticket was mentioned in Slack in #core by boren. View the logs.


6 years ago

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


6 years ago

#6 @ryan
6 years ago

This is a problem again in 4.3. Opened #32779.

Note: See TracTickets for help on using tickets.