WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31245, comment 47


Ignore:
Timestamp:
04/28/2017 11:41:15 PM (3 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31245, comment 47

    initial v1  
    1717* The lack of continuity of our `pre_` filters in these functions makes it completely impossible to improve the `alloptions/notoptions` cache problem without extremely elaborate filters on `query` and so on. Normally I'd prefer to make a plugin as a proof-of-concept, but that is unfortunately impossible here as this API is coded today (and my patch does not make any effort to improve that, though it isn't any more difficult either.)
    1818* Please be open and critical, and scrutinize this deeply. I'm too close to the concept now to make many significant improvements to this patch alone, but I'm convinced that something similar to this approach is the ideal solution today (beyond schema changes, `wp_optionmeta`, etc...)
     19* The way that `options.php` is included at the top of `functions.php` is weird to me, but I rolled with it here.
    1920
    2021Thank you in advance for taking any time to review my patch. 💜