Changes between Initial Version and Version 1 of Ticket #31245, comment 56
- Timestamp:
- 10/15/2017 12:30:04 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31245, comment 56
initial v1 3 3 4 4 5 2. Like @spacedmonkey said, introducing a multi-fetch here is not the proper way to fix the race condition. There is a much easier fix, see fabian-race-fix.diff . The additional condition `wp_using_ext_object_cache()` is necessary because the core implementation of the object cache is actually wrong. `wp_cache_get` should return "not found" whenever `$force` is true on a non-persistent cache.5 2. Like @spacedmonkey said, introducing a multi-fetch here is not the proper way to fix the race condition. I think there is a much easier fix, see fabian-race-fix.diff . The additional condition `wp_using_ext_object_cache()` is necessary because the core implementation of the object cache is actually wrong. `wp_cache_get` should return "not found" whenever `$force` is true on a non-persistent cache.