WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31245, comment 56


Ignore:
Timestamp:
10/15/2017 12:30:04 PM (2 years ago)
Author:
fabifott
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31245, comment 56

    initial v1  
    33
    44
    5 2. Like  @spacedmonkey said, introducing a multi-fetch here is not the proper way to fix the race condition. There is a much easier fix, see fabian-race-fix.diff . The additional condition `wp_using_ext_object_cache()` is necessary because the core implementation of the object cache is actually wrong. `wp_cache_get` should return "not found" whenever `$force` is true on a non-persistent cache.
     52. Like  @spacedmonkey said, introducing a multi-fetch here is not the proper way to fix the race condition. I think there is a much easier fix, see fabian-race-fix.diff . The additional condition `wp_using_ext_object_cache()` is necessary because the core implementation of the object cache is actually wrong. `wp_cache_get` should return "not found" whenever `$force` is true on a non-persistent cache.