WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31245, comment 88


Ignore:
Timestamp:
11/15/2019 10:01:00 AM (5 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31245, comment 88

    initial v1  
    44> I'm not thrilled that it removes tests.
    55
    6 Per discussion starting with comment:82, [attachment:"31245.4.diff"] would be cleaner way of implementing it, allowing existing object caches to choose whether to go with core's `wp_cache_delete( 'alloptions', 'options' )` or unhook it and keep their own implementation for better performance.
     6Per discussion starting with comment:82, [attachment:"31245.4.diff"] would be a cleaner way of implementing it, allowing existing object caches to choose whether to go with core's `wp_cache_delete( 'alloptions', 'options' )` or unhook it and keep their own implementation for better performance.
    77
    88However, I'm leaning towards [attachment:"31245.4.fabian-race-fix.diff"] (a refresh of [attachment:"fabian-race-fix.diff"]). Per comment:83, it appears to be the safest option here that will have an impact while also reducing the side effects. It also doesn't need to remove any tests, the full suite seems to pass as is with the patch applied.