WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31291 closed enhancement (wontfix)

Replace clunky load_plugin_textdomain to remove deprecated parameter

Reported by: strider72 Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.2
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

I think it would be nice to update the textdomain loading to remove the long-deprecated path parameter. There hads been an unused second parameter for many versions now -- it's just a bit of ugly old code.

I'm attaching a patch that replaces the old function with wp_load_plugin_textdomain, turns the old function into a wrapper for the new one, and moves the old one to the deprecated.php

(Suggestions for renaming the function welcome....)

Attachments (1)

wp_load_plugin_textdomain-31291.diff (2.5 KB) - added by strider72 6 years ago.

Download all attachments as: .zip

Change History (3)

#1 @SergeyBiryukov
6 years ago

load_plugin_textdomain() is used in almost every plugin, renaming and deprecating the function would make it inconsistent with load_theme_textdomain() and doesn't seem worth the effort.

#2 @DrewAPicture
6 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with @SergeyBiryukov. We can't just deprecate it because we want to, especially as it's already in use all over the place, and almost certain to be in use by most modern plugins as we move toward a translated plugin repository on wp.org.

Closing as wontfix.

Note: See TracTickets for help on using tickets.