WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#31309 closed enhancement (fixed)

Unused parameters and variables in wp-admin/includes/template.php

Reported by: ipm-frommen's profile ipm-frommen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: template Cc:

Description

  • mark unused parameters unused;
  • remove unused globalization of $current_user variable in iframe_header function;

Attachments (1)

31309.patch​ (1.6 KB) - added by ipm-frommen 10 years ago.

Download all attachments as: .zip

Change History (5)

@ipm-frommen
10 years ago

#1 @ipm-frommen
10 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
10 years ago

  • Component changed from General to Administration

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.2

$default was introduced in [6588], the function was renamed to wp_popular_terms_checklist() in [6713].

$limit_styles was introduced in [9141]. Unused since [18577].

$current_user was introduced in [16882]. Unused since [24187].

I think we can rename $limit_styles and remove $current_user, but I'd like to keep the context of $default in case we decide to implement it later.

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31443:

Rename unused argument and remove obsolete global in iframe_header().

props ipm-frommen.
fixes #31309.

Note: See TracTickets for help on using tickets.