My Sites admin bar link broken when on blogs you have no role on

[simonwheatley]

Steps to reproduce:

0. Create a WordPress multisite
1. Create a new user
2. Create two sites
3. Give the user access to site 1, but not site 2
4. Log in as the user
5. Visit site 2
6. Click on "My Sites" in the admin bar
7. Error message about not having enough privilege

[simonwheatley]

Wrap the add_menu call in switch_to_blog

[simonwheatley]

Ping @jeremyfelt :)

[jeremyfelt]

That's a nice one. I'll take a closer look this evening, but the patch makes sense.

[jeremyfelt]

Confirmed. This definitely leads to a confusing interface for a user. I know I've been annoyed by this screen before. :)

We can use $wp_admin_bar->user->active_blog->blog_id instead, as it's populated properly when the admin bar is first initialized.

[jeremyfelt]

In 31445:

Create the My Sites URL in the context of a user's primary site.

Switch to the user's primary (or active) site before creating the My Sites URL. This previously linked to the current site's dashboard, even if a user was not a member of that site.

Props simonwheatley for the initial patch.

Fixes #31314.

[ocean90]

Use get_admin_url()

[ocean90]

@jeremyfelt Doesn't look 31314.2.diff​ a bit cleaner?

[SergeyBiryukov]

In 31448:

Use get_admin_url() to get the correct My Sites URL without calling switch_to_blog() directly.

props ocean90.
see #31314.