Context Navigation

← Previous Ticket
Next Ticket →

#31333 closed defect (bug) (fixed)

Comment reply link broken in ajax call

Reported by:	aruns6578	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.3
Component:	Comments	Version:	4.1
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Will it be okay to change

esc_url( add_query_arg( 'replytocom', $comment->comment_ID ) ) . "#" . $args['respond_id']

esc_url( add_query_arg( 'replytocom', $comment->comment_ID, get_permalink($post->ID) ) ) . "#" . $args['respond_id']

at line https://core.trac.wordpress.org/browser/tags/4.1/src/wp-includes/comment-template.php#L1412

The get_comment_reply_link function sends wrong URL when requested via ajax call.

Attachments (1)

31333.1.diff (681 bytes ) - added by nazmul.hossain.nihal 11 years ago.: patch for comment-template.php

Download all attachments as: .zip

Change History (10)

@nazmul.hossain.nihal
11 years ago

Attachment 31333.1.diff added

patch for comment-template.php

#1 @nazmul.hossain.nihal
11 years ago

@aruns6578: I just made a patch using your codes.

#2 @nazmul.hossain.nihal
11 years ago

Keywords has-patch added

#3 @SergeyBiryukov
11 years ago

#32277 was marked as a duplicate.

#4 @SergeyBiryukov
11 years ago

Milestone Awaiting Review → 4.3

#5 @SergeyBiryukov
11 years ago

This will probably fix #31100 as well.

This ticket was mentioned in Slack in #core by shelob9. View the logs.

11 years ago

#7 @obenland
11 years ago

Owner set to SergeyBiryukov
Status new → assigned

#8 @rachelbaker
11 years ago

Related #32299

#9 @wonderboymusic
11 years ago

Resolution → fixed
Status assigned → closed

In 32786:

In get_comment_reply_link(), when generating the reply link, add the replytocom query arg to the result of get_permalink() on the current $post, instead of the current global request URI.

Props nazmul.hossain.nihal.
Fixes #31333.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#31333 closed defect (bug) (fixed)

Comment reply link broken in ajax call

Description

Attachments (1)

Change History (10)

@nazmul.hossain.nihal 11 years ago

#1 @nazmul.hossain.nihal 11 years ago

#2 @nazmul.hossain.nihal 11 years ago

#3 @SergeyBiryukov 11 years ago

#4 @SergeyBiryukov 11 years ago

#5 @SergeyBiryukov 11 years ago

This ticket was mentioned in ​Slack in #core by shelob9. ​View the logs. 11 years ago

#7 @obenland 11 years ago

#8 @rachelbaker 11 years ago

#9 @wonderboymusic 11 years ago