WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#31343 closed enhancement (fixed)

Update grunt-sass to 0.18.0

Reported by: netweb Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

Upstream changes:


With the changes in _admin.scss in the included patch there is no difference to any file in /build folder after running grunt build or grunt precommit.

The addition of the leading zero is due to the upstream issue in libsass/issues/623, this is fixed as part of libsass v3.1.

Without the changes all the colors.css files (MP6) result in changes for each e.g:

  • build/wp-admin/css/colors/sunrise/colors.css

    ul#adminmenu a.wp-has-current-submenu:after, ul#adminmenu > li.current > a.curre 
    218218
    219219#wpadminbar #adminbarsearch .adminbar-input::-webkit-input-placeholder {
    220220  color: #fff;
    221   opacity: .7; }
     221  opacity: 0.7; }

Attachments (2)

31343.diff (1.5 KB) - added by netweb 7 years ago.
31343.1.diff (1.5 KB) - added by netweb 7 years ago.

Download all attachments as: .zip

Change History (6)

@netweb
7 years ago

This ticket was mentioned in Slack in #core by netweb. View the logs.


7 years ago

@netweb
7 years ago

#2 @netweb
7 years ago

  • Keywords commit added

In 31343.1.diff​ refreshed against latest /trunk

To reiterate, no changes to the /build folder after running grunt or /src after grunt precommit

#3 @wonderboymusic
7 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31648:

Update grunt-sass to 0.18.0.

Props netweb.
Fixes #31343.

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


7 years ago

Note: See TracTickets for help on using tickets.