Screen options posts/pages/etc. per page label

[afercia]

One small thing reported by Jeff de Wit from the accessibility testers group that wasn't included in the ​last testing session summary:

The label for the posts per page (under screen options) just says "Posts" (or "Pages", or "Comments", or whatever list page you're on). ChromeVox simply announces it as such ("Posts, 20, edit text and numeric only"). It doesn't seem clear that it changes the amount of posts/pages/comments/whatever per page in the admin.

See screenshot:

Proposed patch just add some more context to the label text. Also some minor CSS adjustments. See screenshot after the patch:

[ocean90]

The string in 31349.patch​ isn't translatable. Some related tickets for this string: #13673, #15576

[afercia]

Replying to ocean90:

The string in 31349.patch​ isn't translatable.

Sorry, totally forgot that. Aging issues :) See updated patch. I would propose to just add "per page" for now, which I guess it makes sense in all languages as translatable string. This would give some useful context to screen reader users, and handle the items singular/plural forms in the other tickets.

[ocean90]

printf( '%1$s %2$s', $per_page_label, __( 'per page' ) );: This won't work for languages which need to translate this into something like per $per_page_label page.

#15576 proposes using "Items" always (I'm +1 for it), that would make this easier.

[afercia]

+1 for semplification.
@pavelevap suggested something like "number of items per page".
It would be great to reach some consensus for such a small thing after 4 years and no progress in the last 20 months :)
Then, what about $per_page_label ? it will work just as a "flag"?

[afercia]

Updated patch, as per ​Slack conversation and based on @pavelevap comment on related ticket https://core.trac.wordpress.org/ticket/15576#comment:21 uses always the same text in all screens. See example before/after screenshot:

[pavelevap]

I love it, please commit :-)

"Number of items per page: %" would be more flexible for example for RTL languages, but there is not probably easy way in this case.

[ocean90]

I think we should enhance render_per_page_options() to make 'label' => __( 'Number of items per page:' ) default.

[afercia]

Refreshed patch. Use the new string as default in render_per_page_options() as per @ocean90 suggestion.

[ocean90]

In 31696:

Screen Options: Improve items per page option label.

Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to WP_Screen->render_per_page_options() and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.

[johnbillion]

r31696 broke the <title> on the Posts screen and the Pages screen.

[SergeyBiryukov]

In 31709:

Restore <title> tag on Posts and Pages screens after [31696].

fixes #31349.