Changes between Version 1 and Version 2 of Ticket #31354, comment 31
- Timestamp:
- 06/02/2024 09:49:21 PM (6 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31354, comment 31
v1 v2 3 3 The `aria-live` announcement isn't needed, in my opinion; it would just make things more verbose. If the change was made to something that preceded the current position in the DOM, it might be necessary, but since the change is to items that follow in the DOM, I think it's fine as is. 4 4 5 Edit: and I also added the `disabled` attribute in PHP, so it would apply without JS.6 5 Also changed the CSS & HTML so to reuse the styles from the Reading options screen, updated the function comments to better describe what the added JS now does, and removed the styles that impacted the label design. It's generally considered acceptable for a disabled input to be below color contrast guidelines, but the label still needs to be visible. 7 6 7 Edit: and I also added the `disabled` attribute in PHP, so it would apply without JS.