Order By Description does not work in edit-tags.php

[neil_pie]

In WP_Terms_List_Table, 'description' is defined as a sortable column, yet when clicking on the column header in the UI, the table sorts by name instead.

This seems to be because 'description' is missed out of the predefined arguments for the 'orderby' parameter in get_terms(), and so the default orderby of t.name is applied.

This patch adds 'description' as an option, ordering on the tt.descripton field

[neil_pie]

Of note - if this patch is accepted, I can change the Codex page for get_terms accordingly

​http://codex.wordpress.org/Function_Reference/get_terms

[boonebgorges]

As discussed in Slack:

• The problem was introduced when edit-tags.php was converted to list tables [15491]. The sorting has therefore never worked properly.
• There was some question surrounding the question of whether most people would want this data to be sortable. If you are using sentences to describe your terms (as suggested, I think, by the term "description"), it probably doesn't make sense to sort alphabetically by 'description'.
• That being said, it's easy to imagine ways of using the 'description' field in a way that would make sort-by-description a useful feature, and there's no harm in adding it, so onward we march.

[boonebgorges]

In 31532:

Add 'orderby=description' support to get_terms().

This fixes an interface inconsistency in edit-tags.php, where Description
appears as a sortable column header.

Props neil_pie.
Fixes #31364.