WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31371 closed defect (bug) (duplicate)

wp_enqueue_script doesn't load all scripts due to $concat = str_split( $concat, 128 );

Reported by: alturic Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.1
Component: Script Loader Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

So, I came across this ticket that was marked Closed and I'm unsure what me reopening it will actually do hence I'm making this ticket for WordPress 4.1 but the "issue" still remains.

#26886

Either way the "problem" comes when the Query Params reach 128 chars, and I don't really want to just edit a WP Core file for multiple reasons BUT I fix it by simply changing

$concat = str_split( $concat, 128 );

to

$concat = str_split( $concat, 3000 );

and everything seems to work fine, all the scripts now load, etc. I don't have the problem anymore or anything but a.) it's editing a core file (blah) and b.) I'm unsure what all can happen by simply doing that.

For reference, here's some screenshots showing what was happening:

http://i.imgur.com/3Gz3lTL.png

http://i.imgur.com/thRlvXI.png

Change History (1)

#1 @SergeyBiryukov
6 years ago

  • Description modified (diff)
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

As noted in comment:5:ticket:26886 and comment:11:ticket:26886, the string is merged back together before being split by commas and processed, so the 128 character limit shouldn't make a difference.

Let's continue the discussion in #26886.

Note: See TracTickets for help on using tickets.