Twenty Fourteen: twentyfourteen_post_thumbnail() should be pluggable

[WordPressor.ru]

Hi all, this is my first.

In file wp-content/themes/twentyfourteen/inc/template-tags.php, there is missed "if ( ! function_exists(" around function twentyfourteen_post_thumbnail. So I can't redefine this function in my child theme.

I'm using WP 4.1, Twentyfourteen theme 1.3.

See my diff, hope i made it right.

Also, there are same construction missing around function twentyfourteen_categorized_blog in same template-tag.php.

[philiparthurmoore]

[Changing my comment since the original was wrong.]

Hi! Just a note about why twentyfourteen_categorized_blog doesn't have a function_exists around it. If I recall correctly there was discussion about a related issue ​elsewhere. The reasoning there was that the function is so specific that it doesn't need to be overridden. Reasoning may have changed since then. I'm sure others can provide better context but I wanted to chime in about why that doesn't have a function check around it.

[SergeyBiryukov]

Good catch, twentyfifteen_post_thumbnail() is pluggable in Twenty Fifteen.

Makes sense for twentyfourteen_post_thumbnail() to be pluggable too.

[lancewillett]

In 31481:

Twenty Fourteen: make twentyfourteen_post_thumbnail() pluggable.

Fixes #31374, props wordpressorru.

[DrewAPicture]

I'd like to have a changelog entry added to the phpDoc for this function mentioning that it was made pluggable in Twenty Fourteen 1.X

[WordPressor.ru]

both twentyfourteen_post_thumbnail and twentyfourteen_categorized_blog are pluggable

[WordPressor.ru]

Thank you all!
What about twentyfourteen_categorized_blog() in the same file?
I fixed them both in combined patch.

[SergeyBiryukov]

Replying to WordPressor.ru:

What about twentyfourteen_categorized_blog() in the same file?

As mentioned in comment:1, twentyfourteen_categorized_blog() seems specific and probably doesn't need to be overridden. It's not pluggable in Twenty Fifteen either.

Is there an actual use case for it to be overridden?

[DrewAPicture]

In 31482:

Add an entry to the changelog for twentyfourteen_post_thumbnail() noting that it was made 'pluggable'.

Fixes #31374.

[WordPressor.ru]

In my case, there is no need to display category name in post meta.
twentyfourteen_categorized_blog() in my child theme always returns false.
Perfect solution, for me at least.

[SergeyBiryukov]

Let's create a new ticket for twentyfourteen_categorized_blog() then.

A workaround:

function wp31374_override_twentyfourteen_categorized_blog() {
	return 1;
}
add_filter( 'pre_transient_twentyfourteen_category_count', 'wp31374_override_twentyfourteen_categorized_blog' );