Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#31381 closed defect (bug) (fixed)

The theme details modal has scrolling and toolbar problems on iPhone 6 and 6+

Reported by: ryan's profile ryan Owned by: ocean90's profile ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Themes Keywords: make-flow has-patch commit
Focuses: ui Cc:

Description

Visit themes.php on an iPhone 6 or 6+. Tap a theme to bring up the details modal. Note that the modal's nav buttons are beneath the toolbar. Scrolling is very awkward, and the toolbar detaches from the top and follows your finger. This screen is very difficult to use.

Attachments (4)

img_0579.png (914.8 KB) - added by ryan 10 years ago.
Modal nav controls hidden beneath toolbar
img_0580.png (698.6 KB) - added by ryan 10 years ago.
Toolbar detaches when scrolling
31381.diff (431 bytes) - added by obenland 10 years ago.
31381.1.diff (620 bytes) - added by obenland 10 years ago.

Download all attachments as: .zip

Change History (19)

@ryan
10 years ago

Modal nav controls hidden beneath toolbar

@ryan
10 years ago

Toolbar detaches when scrolling

This ticket was mentioned in Slack in #core-flow by boren. View the logs.


10 years ago

@obenland
10 years ago

#3 @obenland
10 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

z-indexes should die in a fire.

Bug introduced in r30764.

#4 @obenland
10 years ago

This might be a candidate for 4.1.2 as well, since it fixes a bug introduced in 4.1.

#5 follow-up: @ryan
10 years ago

Much better. I tested on Nexus 5, iPhone 5, and iPhone 6+. No problems on the Nexus 5. The iPhones are good except for slight detachment of the bottom button bar when scrolling. The bottom bar detaches slightly and the underlying page bleeds through. The toolbar no longer detaches or obscures modal nav.

#6 in reply to: ↑ 5 @obenland
10 years ago

Replying to ryan:

The iPhones are good except for slight detachment of the bottom button bar when scrolling. The bottom bar detaches slightly and the underlying page bleeds through. The toolbar no longer detaches or obscures modal nav.

Yes, this seems to happen whenever Safari shows or hides the bottom and top toolbars on scrolling. Specifically with themes that don't have a lot of information attached, like a short description, few tags, that doesn't let the user scroll much. Not sure how to avoid that.

@obenland
10 years ago

#7 @obenland
10 years ago

Updated patch also brings back momentum scrolling on iOS devices.

#8 @ryan
10 years ago

31381.1.diff looks good here. Pretty smooth. I did a visual survey of the modal on multiple devices while testing the patch.

https://make.wordpress.org/flow/2015/03/02/theme-details-modal-survey/

This ticket was mentioned in Slack in #core by boren. View the logs.


10 years ago

#10 @lancewillett
10 years ago

  • Keywords commit added

#11 @lancewillett
10 years ago

Patch looks good.

#12 @helen
10 years ago

#31542 was marked as a duplicate.

This ticket was mentioned in Slack in #core by boren. View the logs.


10 years ago

#14 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31702:

Theme Details: Hide admin toolbar on smaller screens.

props obenland.
fixes #31381.

This ticket was mentioned in Slack in #core-flow by drew. View the logs.


10 years ago

Note: See TracTickets for help on using tickets.