Opened 12 years ago
Last modified 2 months ago
#31384 new defect (bug)
Pingback does not work for schemeless URLs
| Reported by: | tobiaskochsonlinenet | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Pings/Trackbacks | Version: | 1.5 |
| Severity: | normal | Keywords: | has-patch has-unit-tests |
| Cc: | Focuses: |
Description
I noticed that a pingback will not be send if the target URL is given as a schemeless URL (like //www.example.com/path/file.ext.
This is because discover_pingback_server_uri() in comment.php is using the PHP function parse_url() which cannot handle schemeless URLs correctly.
Attachments (1)
Change History (10)
#3
@
11 years ago
- Keywords needs-unit-tests needs-patch added
Test coverage ought to discover_pingback_server_uri() should pick this up via https://github.com/aaronjorbin/develop.wordpress which gets tested on Travis.
Also http://3v4l.org/ is useful for testing code across PHP versions.
This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.
10 years ago
This ticket was mentioned in PR #12543 on WordPress/wordpress-develop by @sainathpoojary.
2 months ago
#9
- Keywords has-unit-tests added; needs-unit-tests removed
Trac ticket: #31384
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Noting that PHP docs state that 5.4.7 corrects this. http://php.net/manual/en/function.parse-url.php