Opened 10 years ago
Last modified 6 years ago
#31384 new defect (bug)
Pingback does not work for schemeless URLs
Reported by: | tobiaskochsonlinenet | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 1.5 |
Component: | Pings/Trackbacks | Keywords: | has-patch needs-unit-tests |
Focuses: | Cc: |
Description
I noticed that a pingback will not be send if the target URL is given as a schemeless URL (like //www.example.com/path/file.ext
.
This is because discover_pingback_server_uri() in comment.php is using the PHP function parse_url() which cannot handle schemeless URLs correctly.
Attachments (1)
Change History (9)
#3
@
10 years ago
- Keywords needs-unit-tests needs-patch added
Test coverage ought to discover_pingback_server_uri()
should pick this up via https://github.com/aaronjorbin/develop.wordpress which gets tested on Travis.
Also http://3v4l.org/ is useful for testing code across PHP versions.
This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.
9 years ago
Note: See
TracTickets for help on using
tickets.
Noting that PHP docs state that 5.4.7 corrects this. http://php.net/manual/en/function.parse-url.php