WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 13 months ago

#31384 new defect (bug)

Pingback does not work for schemeless URLs

Reported by: tobiaskochsonlinenet Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 1.5
Component: Pings/Trackbacks Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

I noticed that a pingback will not be send if the target URL is given as a schemeless URL (like //www.example.com/path/file.ext.
This is because discover_pingback_server_uri() in comment.php is using the PHP function parse_url() which cannot handle schemeless URLs correctly.

Attachments (1)

31384.diff (537 bytes) - added by dshanske 18 months ago.
Switch to wp_parse_url which has backward compatibility

Download all attachments as: .zip

Change History (9)

#1 @DrewAPicture
3 years ago

  • Version changed from trunk to 1.5

#2 @kraftbj
2 years ago

Noting that PHP docs state that 5.4.7 corrects this. http://php.net/manual/en/function.parse-url.php

#3 @johnbillion
2 years ago

  • Keywords needs-unit-tests needs-patch added

Test coverage ought to discover_pingback_server_uri() should pick this up via https://github.com/aaronjorbin/develop.wordpress which gets tested on Travis.

Also http://3v4l.org/ is useful for testing code across PHP versions.

#4 @dshanske
19 months ago

This should work if we change to wp_parse_url

@dshanske
18 months ago

Switch to wp_parse_url which has backward compatibility

#5 @dshanske
18 months ago

  • Keywords has-patch added; needs-unit-tests needs-patch removed

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


18 months ago

#7 @rachelbaker
18 months ago

  • Keywords needs-unit-tests added

Still needs a unit test to confirm.

#8 @dshanske
13 months ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.