Make WordPress Core

Opened 12 years ago

Last modified 2 months ago

#31384 new defect (bug)

Pingback does not work for schemeless URLs

Reported by: tobiaskochsonlinenet Owned by:
Priority: normal Milestone:
Component: Pings/Trackbacks Version: 1.5
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description

I noticed that a pingback will not be send if the target URL is given as a schemeless URL (like //www.example.com/path/file.ext.
This is because discover_pingback_server_uri() in comment.php is using the PHP function parse_url() which cannot handle schemeless URLs correctly.

Attachments (1)

31384.diff (537 bytes ) - added by dshanske 10 years ago.
Switch to wp_parse_url which has backward compatibility

Download all attachments as: .zip

Change History (10)

#1 @DrewAPicture
11 years ago

  • Version trunk1.5

#2 @kraftbj
11 years ago

Noting that PHP docs state that 5.4.7 corrects this. http://php.net/manual/en/function.parse-url.php

#3 @johnbillion
11 years ago

  • Keywords needs-unit-tests needs-patch added

Test coverage ought to discover_pingback_server_uri() should pick this up via https://github.com/aaronjorbin/develop.wordpress which gets tested on Travis.

Also http://3v4l.org/ is useful for testing code across PHP versions.

#4 @dshanske
10 years ago

This should work if we change to wp_parse_url

@dshanske
10 years ago

Switch to wp_parse_url which has backward compatibility

#5 @dshanske
10 years ago

  • Keywords has-patch added; needs-unit-tests needs-patch removed

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


10 years ago

#7 @rachelbaker
10 years ago

  • Keywords needs-unit-tests added

Still needs a unit test to confirm.

#8 @dshanske
10 years ago

  • Milestone Awaiting ReviewFuture Release

This ticket was mentioned in PR #12543 on WordPress/wordpress-develop by @sainathpoojary.


2 months ago
#9

  • Keywords has-unit-tests added; needs-unit-tests removed

Trac ticket: #31384

Note: See TracTickets for help on using tickets.