WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#31410 closed enhancement (wontfix)

Add constant for disabling updates

Reported by: elusiveunit Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.2
Component: Upgrade/Install Keywords: has-patch dev-feedback
Focuses: Cc:

Description

We host a bunch of sites where the code is managed centrally with git and symlinks, making updates a manual task. Having WordPress check for updates is therefore pretty pointless in this case (and in the case of #31011 made our logs get filled with warnings).

Unregistering all the update hooks and filtering some other stuff where needed works, but is a bit of a hassle to keep track of. Having a single constant to completely disable the update system would be great.

The with-30947 patch is based on 30947.2.diff from SergeyBiryukov in #30947 being applied, so it's currently broken for trunk. The other patch does the rest.

I'm not super familiar with the internals, so I've probably missed some areas.

Attachments (2)

31410.patch (2.7 KB) - added by elusiveunit 6 years ago.
31410-with-30947.patch (759 bytes) - added by elusiveunit 6 years ago.

Download all attachments as: .zip

Change History (7)

@elusiveunit
6 years ago

#1 @elusiveunit
6 years ago

  • Keywords has-patch added

#2 @elusiveunit
6 years ago

  • Keywords dev-feedback added

#3 @DrewAPicture
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi elusiveunit,

This falls squarely in plugin territory. Core makes some accommodations for managing automatic updates via constants, though I don't predict we would add something to globally disable all updates any time in the near future.

#4 @SergeyBiryukov
6 years ago

There's a DISALLOW_FILE_MODS constant that should effectively disable updates, including core.

#5 @elusiveunit
6 years ago

I see, too bad.

We do use DISALLOW_FILE_MODS, but the point here was to skip the mentioned update checks that are still unnecessarily run two times a day on dozens of sites. Our hook solution works though, even if it's a bit clunky.

Note: See TracTickets for help on using tickets.