WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#31417 closed defect (bug) (fixed)

go_to function breaks when path isn't set

Reported by: joostdevalk Owned by: boonebgorges
Priority: normal Milestone: 4.2
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

When using go_to to go to the un-trailingslashed home, it fails because of a lacking path after the url is parsed.

Attachments (1)

patch-31417.diff​ (510 bytes ) - added by joostdevalk 12 years ago.
Patch

Download all attachments as: .zip

Change History (3)

@joostdevalk
12 years ago

Patch

#1 @boonebgorges
12 years ago

  • Milestone Awaiting Review → 4.2

Looks good. Thanks for the patch.

#2 @boonebgorges
12 years ago

  • Owner set to boonebgorges
  • Resolution → fixed
  • Status new → closed

In 31515:

Ensure that a request URL is always set in WP_UnitTestCase::go_to().

Failure to set this variable meant that passing the home URL to go_to()
(without a trailing slash) resulted in a PHP notice, and failed to reset the
globals properly.

Props joostdevalk.
Fixes #31417.

Note: See TracTickets for help on using tickets.