WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#31426 closed defect (bug) (fixed)

Admin nav menu "Open link in a new window/tab" lacks spacing on top

Reported by: tyxla Owned by: SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Menus Keywords: has-patch
Focuses: administration Cc:

Description

In admin nav menus, the expanded item "Open link in a new window/tab" field lacks spacing on top, which causes it to be positioned too close to the top fields.

After further investigation, I discovered that this comes from incorrect height that is set to .description-thin. If this height is removed, the .description-thin will grow to as much height as necessary, which fixes the issue.

Attachments (2)

31426.patch (314 bytes) - added by tyxla 7 years ago.
Removing hardcoded height from .description-thin, allowing it to grow as much as necessary.
31426.png (18.3 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (6)

@tyxla
7 years ago

Removing hardcoded height from .description-thin, allowing it to grow as much as necessary.

#1 @tyxla
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.2

@SergeyBiryukov
7 years ago

#3 @SergeyBiryukov
7 years ago

Like with #31425, it's always a good idea to add screenshots for UI changes :)

Looks good, see 31426.png.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31524:

Menus: Remove fixed height from .description-thin fields.

props tyxla.
fixes #31426.

Note: See TracTickets for help on using tickets.