#31430 closed defect (bug) (fixed)
Tests_Post_Template::test_wp_dropdown_pages is failing
Reported by: | valendesigns | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Posts, Post Types | Keywords: | needs-patch |
Focuses: | Cc: |
Description
1) Tests_Post_Template::test_wp_dropdown_pages Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ '<select name='page_id' id='page_id'> <option class="level-0" value="130">Post title 1</option> <option class="level-1" value="131"> Post title 2</option> <option class="level-2" value="132"> Post title 3</option> </select> ' /tests/phpunit/tests/post/template.php:95
Change History (5)
#1
@
10 years ago
- Component changed from Build/Test Tools to Posts, Post Types
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 4.2
#2
@
10 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
#3
follow-up:
↓ 4
@
10 years ago
Apparently patching unit test files with grunt patch
on Windows changes line endings.
We should probably set svn:eol-style
to native for test files, like we did for core, but that breaks some tests that use the heredoc syntax (<<<
), like Tests_Post_Template::test_wp_dropdown_pages()
here.
[31531] fixes the issue at hand for now.
#4
in reply to:
↑ 3
;
follow-up:
↓ 5
@
10 years ago
Replying to SergeyBiryukov:
Apparently patching unit test files with
grunt patch
on Windows changes line endings.
We should probably set
svn:eol-style
to native for test files, like we did for core, but that breaks some tests that use the heredoc syntax (<<<
), likeTests_Post_Template::test_wp_dropdown_pages()
here.
[31531] fixes the issue at hand for now.
Could we safely update the tests to use a different syntax?
In 31531: