Press This: Mega checkboxes in IE and Firefox

[Michael Arestad]

This is due to an attempt at focus styles on the categories list. The best thing to do would be to change the categories list markup to li elements.

Pros:

• full style control
• A11y win (list tells how many items are in it)
• removal of super hacky CSS targeting browsers

Working example: ​http://test.cita.uiuc.edu/aria/checkbox/checkbox1.php

[azaozz]

In 31443.patch:

• Add option to output only list items (no checkboxes) in wp_terms_checklist().
• Update the JS to use the list items instead of checkboxes.

Needs styling.

[Michael Arestad]

Started styling this. I'm attaching what I've done so far, but as you'll see, there is some serious padding issues due to the nesting. Any way we could change the layout a little? Something like this would work:

<ul>
  <li>
    <div aria and checkbox stuff>Category name</div>
    <ul>
      <li>
        <div aria and checkbox stuff>Category name</div>
      </li>
    </ul>
  </li>
</ul>

Current screenshot of janky padding:

[azaozz]

Replying to Michael Arestad:

Any way we could change the layout a little?

Done in 31443.3.patch :)

[Michael Arestad]

Added patch works pretty well.

Firefox and IE8:

[azaozz]

In 31765:

PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form.
Part prop: Michael-Arestad. Fixes #31443.

[azaozz]

In 31775:

PressThis: add a wrapped with role = application to the categories section.
Props: afercia. See #31443.

[azaozz]

In 31907:

Press This: remove role="application" from the Categories list wrapper. This doesn't make it work better in screen readers.
See #31443.

[rianrietveld]

In addition to comment 10 by @azaozz: Screen reader test results for role="application" are at ​https://make.wordpress.org/accessibility/2015/03/26/usertest-extra-small-test-about-roleapplication-in-press-this/

[stephdau]

NIce!

[DrewAPicture]

In 34368:

Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765].

See #31443. See #32246.