WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31449 closed enhancement (fixed)

Press This accessibility improvements

Reported by: afercia Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: has-patch
Focuses: accessibility, javascript Cc:

Description

Proposed patch addresses following issues, some of them marked as "errors" by WAVE evaluation tool:

Errors:

  • 2 X Missing form label (url-scan and wp-editor-area, won't touch the latter)
  • 1 X Empty form label (search categories)
  • 1 X Empty heading (won't touch this, there's ongoing discussion on this h2)
  • 1 X Empty button (add-cat-toggle button-subtle)

Additionally:

  • added some screen-reader-text and aria-hidden attributes
  • added "aria-expanded" on some buttons
  • focus handling improvements
  • added missing target id for aria-controls="pressthis-code-wrap" in /wp-admin/tools.php
  • changed tagcloud-link into a button

Attachments (1)

31449.patch (9.1 KB) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added

#2 @stephdau
5 years ago

Patch is looking good and working well in my test of it.

Last edited 5 years ago by stephdau (previous) (diff)

#3 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.2

#4 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31566:

PressThis: accessibility enhancements:

  • Add missing form labels.
  • Add some screen-reader-text and aria-hidden attributes.
  • Focus handling improvements.
  • Change tagcloud-link into a button.
  • Add missing ID attribute in tools.php.

Props afercia. Fixes #31449.

Note: See TracTickets for help on using tickets.