Context Navigation

← Previous Ticket
Next Ticket →

#31449 closed enhancement (fixed)

Press This accessibility improvements

Reported by:	afercia	Owned by:	azaozz
Priority:	normal	Milestone:	4.2
Component:	Press This	Version:	4.2
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	accessibility, javascript

Description

Proposed patch addresses following issues, some of them marked as "errors" by WAVE evaluation tool:

Errors:

2 X Missing form label (url-scan and wp-editor-area, won't touch the latter)
1 X Empty form label (search categories)
1 X Empty heading (won't touch this, there's ongoing discussion on this h2)
1 X Empty button (add-cat-toggle button-subtle)

Additionally:

added some screen-reader-text and aria-hidden attributes
added "aria-expanded" on some buttons
focus handling improvements
added missing target id for aria-controls="pressthis-code-wrap" in /wp-admin/tools.php
changed tagcloud-link into a button

Attachments (1)

31449.patch (9.1 KB ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (5)

@afercia
11 years ago

Attachment 31449.patch added

#1 @afercia
11 years ago

Keywords has-patch added

#2 @stephdau
11 years ago

Patch is looking good and working well in my test of it.

Last edited 11 years ago by stephdau (previous) (diff)

#3 @SergeyBiryukov
11 years ago

Milestone Awaiting Review → 4.2

#4 @azaozz
11 years ago

Owner set to azaozz
Resolution → fixed
Status new → closed

In 31566:

PressThis: accessibility enhancements:

Add missing form labels.
Add some screen-reader-text and aria-hidden attributes.
Focus handling improvements.
Change tagcloud-link into a button.
Add missing ID attribute in tools.php.

Props afercia. Fixes #31449.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core