WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31456 closed defect (bug) (fixed)

Press This: Fix alert styles by adding `alert` class

Reported by: Michael Arestad Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

Currently each alert should have an alert and either is-notice or is-error to add appropriate styles (regardless of html semantics). This patch should fix it. Could use some @azaozz eyes on it.

Attachments (1)

31456.patch (519 bytes) - added by Michael Arestad 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @Michael Arestad
5 years ago

Before:
https://cldup.com/XIItkhTeM2.png

After:
https://cldup.com/Yl-cu8RnBL.png

#2 @Michael Arestad
5 years ago

  • Keywords has-patch added

#3 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31549:

Press This: fix notices/errors classes. Props michael-arestad. Fixes #31456.

#4 @wonderboymusic
5 years ago

In 31552:

Add missing access modifiers to WP_Press_This.

See #31456.

#5 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.2
Note: See TracTickets for help on using tickets.