WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #31459, comment 37


Ignore:
Timestamp:
10/07/2015 06:23:46 AM (4 years ago)
Author:
hugobaeta
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31459, comment 37

    initial v1  
    88
    99Note, @afercia - I purposefully didn't touch the outline on the focus styles in these patches. I was thinking of leaving that for your ticket, since it's already open.
     10
     11Also, another note, it's important to remember that controlling contrast in the color schemes is a complicated business, since it all depends of the colors people use there. @helen mentioned the lack of contrast on the Midnight scheme, but actually there are worst ones. The only way we could control that would be to use a Sass library to assess color contrast between text color and button background. Maybe [http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass something like this], but I know I've seen more evolved solutions, just need to research it better if that's the way we wanna go. Either way, I think this is out of scope to this ticket, and should be addressed elsewhere IMO ;)