MCE Views - Don't restrict importing of styles to AV views.

[mattheu]

FIrstly - some great improvements to the MCE view code recently - see #31412.

I would like to register a custom view which is sometimes sandboxed in an iFrame. I would also like to have the styles imported from the editor.

However this is hardcoded to only do this for video, audio and playlists.

importStyles = this.type === 'video' || this.type === 'audio' || this.type === 'playlist';

I think this should be a property on the view object - set to false by default but true for the AV views. This would allow me to easily enable it for my views.

Patch incomming.

[iseulde]

Yep, we should rework that too.

[iseulde]

Not sure if there's any reason to not do this all the time.

[mattheu]

Not sure if there's any reason to not do this all the time.

Agreed - I think thats pretty much the point of the sandbox functionality.

Attached an updated patch.

[iseulde]

Refreshed your patch and made the cache private.

[mattheu]

I wonder if styles should only be imported in setIframes if head is null?

[iseulde]

I'll investigate this a bit more. I think there are a few problems with these styles in general.

[DrewAPicture]

Unfortunately this just didn't get done in time for 4.2. Let's try again in 4.3.

[iseulde]

Refreshed the patch. We can refine which styles get added later and see if there are any problems. This is for audio and video too, because some styles don't seem to be added.

[azaozz]

In 31742:

TinyMCE wpViews: always import the non-default editor styles in the sandbox iframe in views.
Props iseulde, mattheu. Fixes #31464.

[azaozz]

In 31757:

TinyMCE wpViews: fix typos in the conditional checking which stylesheets to import.
Props mattheu. See #31464.