Opened 10 years ago
Closed 10 years ago
#31472 closed task (blessed) (fixed)
Press This: Header improvements
Reported by: | DrewAPicture | Owned by: | michael-arestad |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Press This | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
In the revamped Press This header, the styling is meant to mimc the styling of the Toolbar. In #31234, the default color scheme was updated, so we should update it in Press This as well.
We should also link the site name in the header with the the admin index URL. This would be helpful for when you're leveraging Press This via the direct link and want a quick way to get back to your dashboard.
Attachments (4)
Change History (16)
#1
@
10 years ago
Couple of things:
- Would there be a way to make it that PT uses an existing class so it gets core-wide color changes automatically in the future, somehow?
- Site title link: see start in 31472.diff.
- Will need styling
- do we want
target="_blank"
on it? (seems fitting) - do we want
rel="home"
on it? - we could do some JS magic so the whole
H1
becomes clickable, meaning clicking on the WP logo to the left of the site's name will also work, but I think we'd then need awindow.open()
to emulate the behavior oftarget="_blank"
on the link.
Thoughts?
#2
@
10 years ago
@stephdau Depends on how we break up the CSS. If we start using core CSS components (that build into press-this.css) it would be pretty automated. I'll be digging around this weekend looking into things like this.
#4
@
10 years ago
On making the H1 clickable: since it's just for the logo to be clickable, maybe we can style it on the new link tag for the title instead? Then we don't have the JS magic conundrum with opening a new window via JS (and it being blocked, etc).
#5
@
10 years ago
On making the H1 clickable: since it's just for the logo to be clickable, maybe we can style it on the new link tag for the title instead? Then we don't have the JS magic conundrum with opening a new window via JS (and it being blocked, etc).
I'm not sure I follow.
#6
@
10 years ago
@stephdau updated the patch with some styling. I also wrapped both the logo icon and text with the anchor.
#7
@
10 years ago
I like it. And you did what I intended to do with having the logo clickable (had somehow not noticed it was an empty span that was styled, and that it could be moved inside. No need to make the H1 clickable. Thanks.
Start of having a link on the site title.