Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#31472 closed task (blessed) (fixed)

Press This: Header improvements

Reported by: drewapicture's profile DrewAPicture Owned by: michael-arestad's profile michael-arestad
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Press This Keywords: has-patch
Focuses: ui Cc:

Description

In the revamped Press This header, the styling is meant to mimc the styling of the Toolbar. In #31234, the default color scheme was updated, so we should update it in Press This as well.

We should also link the site name in the header with the the admin index URL. This would be helpful for when you're leveraging Press This via the direct link and want a quick way to get back to your dashboard.

Attachments (4)

press_this_header_before.png (20.6 KB) - added by DrewAPicture 10 years ago.
default_color_scheme_header.png (46.6 KB) - added by DrewAPicture 10 years ago.
31472.diff (1.3 KB) - added by stephdau 10 years ago.
Start of having a link on the site title.
31472.patch (2.1 KB) - added by Michael Arestad 10 years ago.

Download all attachments as: .zip

Change History (16)

@stephdau
10 years ago

Start of having a link on the site title.

#1 @stephdau
10 years ago

Couple of things:

  • Would there be a way to make it that PT uses an existing class so it gets core-wide color changes automatically in the future, somehow?
  • Site title link: see start in 31472.diff.
    • Will need styling
    • do we want target="_blank" on it? (seems fitting)
    • do we want rel="home" on it?
    • we could do some JS magic so the whole H1 becomes clickable, meaning clicking on the WP logo to the left of the site's name will also work, but I think we'd then need a window.open() to emulate the behavior of target="_blank" on the link.

Thoughts?

#2 @Michael Arestad
10 years ago

@stephdau Depends on how we break up the CSS. If we start using core CSS components (that build into press-this.css) it would be pretty automated. I'll be digging around this weekend looking into things like this.

#3 @stephdau
10 years ago

Awesome.

#4 @stephdau
10 years ago

On making the H1 clickable: since it's just for the logo to be clickable, maybe we can style it on the new link tag for the title instead? Then we don't have the JS magic conundrum with opening a new window via JS (and it being blocked, etc).

#5 @Michael Arestad
10 years ago

On making the H1 clickable: since it's just for the logo to be clickable, maybe we can style it on the new link tag for the title instead? Then we don't have the JS magic conundrum with opening a new window via JS (and it being blocked, etc).

I'm not sure I follow.

#6 @Michael Arestad
10 years ago

@stephdau updated the patch with some styling. I also wrapped both the logo icon and text with the anchor.

#7 @stephdau
10 years ago

I like it. And you did what I intended to do with having the logo clickable (had somehow not noticed it was an empty span that was styled, and that it could be moved inside. No need to make the H1 clickable. Thanks.

#8 @Michael Arestad
10 years ago

  • Keywords has-patch added; needs-patch removed

#9 @DrewAPicture
10 years ago

  • Owner set to michael-arestad
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by johnbillion. View the logs.


10 years ago

#11 @johnbillion
10 years ago

  • Keywords good-first-bug removed
  • Type changed from enhancement to task (blessed)

#12 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31807:

Press This: fix the header styling and add a logo.
Props Michael-Arestad. Fixes #31472.

Note: See TracTickets for help on using tickets.