WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#31474 closed defect (bug) (fixed)

Press This: RTL issues

Reported by: ocean90 Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords: needs-patch
Focuses: rtl Cc:

Description

  • For some reasons the html element in the content iframe doesn't get dir="rtl"
  • add_editor_style() doesn't include the RTL stylesheet
  • The arrows need to be swapped, currently included with <span class="dashicons dashicons-arrow-right-alt2"></span>

Attachments (2)

31474.patch (592 bytes) - added by ocean90 7 years ago.
Fix for add_editor_style()
31474.2.patch (3.3 KB) - added by ocean90 7 years ago.
Fix for arrows

Download all attachments as: .zip

Change History (4)

@ocean90
7 years ago

Fix for add_editor_style()

@ocean90
7 years ago

Fix for arrows

#1 @ocean90
7 years ago

In 31577:

Press This: RTL improvements.

  • Load the RTL version of press-this-editor.css.
  • Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.

#2 @azaozz
7 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31580:

PressThis TinyMCE: set 'directionality' and add the LTR button when in RTL. Fixes #31474.

Note: See TracTickets for help on using tickets.