WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#31477 closed defect (bug) (fixed)

Build task is overwriting minified JS libraries with our uglified version

Reported by: iseulde Owned by: jorbin
Milestone: 4.2 Priority: low
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description


Attachments (5)

31477.patch (961 bytes) - added by iseulde 4 years ago.
build-31477.diff (135.9 KB) - added by netweb 4 years ago.
build-31477-grunt-uglify-core.diff (36.7 KB) - added by netweb 4 years ago.
31477.diff (630 bytes) - added by jorbin 4 years ago.
31477.1.diff (15.4 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (13)

@iseulde
4 years ago

#1 @ocean90
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

@netweb
4 years ago

#2 @netweb
4 years ago

Sanity checking diffs:

  • build-31477.diff​ - /build folder diff via 31477.patch​
  • build-31477-grunt-uglify-core.diff​ - diff of verbose Grunt task grunt uglify:core --verbose

#3 @DrewAPicture
4 years ago

  • Keywords dev-feedback added
  • Owner set to jorbin
  • Status changed from new to reviewing

@jorbin: Can you please review the patch and try to determine if that's all we need to fix the problem?

@jorbin
4 years ago

#4 @jorbin
4 years ago

I don't like the idea of running uglify on built JS by default. I think we are better off adding in the exceptions we need to our rules (or even better, moving everything not WP into a proper vendors folder). My above patch does this.

@ocean90
4 years ago

#5 @ocean90
4 years ago

  • Keywords commit added; dev-feedback removed
  • Priority changed from normal to low

31477.1.diff is 31477.diff plus alphabetical order and it removes sourceMappingURL from underscore.min.js since the map isn't bundled and so produces a 404 error, see #25072 for jQuery.

#6 @iseulde
4 years ago

Works for me.

#7 @jorbin
4 years ago

In 32065:

Don't reference underscore.js source map

We don't bundle the source map, so we shouldn't reference it. This prevents a 404.

Props ocean90
See #31477

#8 @jorbin
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 32066:

Don't override minified libraries included in core

A number of libraries that we include in core come with minified versions that we also include in core. The build process shouldn't override them.

Fixes #31477
Props ocean90, jorbin

Note: See TracTickets for help on using tickets.