Opened 10 years ago
Closed 10 years ago
#31477 closed defect (bug) (fixed)
Build task is overwriting minified JS libraries with our uglified version
Reported by: | iseulde | Owned by: | jorbin |
---|---|---|---|
Milestone: | 4.2 | Priority: | low |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Attachments (5)
Change History (13)
#3
@
10 years ago
- Keywords dev-feedback added
- Owner set to jorbin
- Status changed from new to reviewing
@jorbin: Can you please review the patch and try to determine if that's all we need to fix the problem?
#4
@
10 years ago
I don't like the idea of running uglify on built JS by default. I think we are better off adding in the exceptions we need to our rules (or even better, moving everything not WP into a proper vendors folder). My above patch does this.
#5
@
10 years ago
- Keywords commit added; dev-feedback removed
- Priority changed from normal to low
31477.1.diff is 31477.diff plus alphabetical order and it removes sourceMappingURL
from underscore.min.js since the map isn't bundled and so produces a 404 error, see #25072 for jQuery.
Note: See
TracTickets for help on using
tickets.
Sanity checking diffs:
build-31477.diff
-/build
folder diff via31477.patch
build-31477-grunt-uglify-core.diff
- diff of verbose Grunt taskgrunt uglify:core --verbose