WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#31478 closed enhancement (fixed)

RTLCSS should swap Dashicons left/right arrows

Reported by: ocean90 Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Instead of adding a .rtl case each time we reference a rigt or left arrow from Dashicons RTLCSS should handle this.

Attachments (2)

31478.patch (3.1 KB) - added by ocean90 7 years ago.
build.patch (5.3 KB) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
7 years ago

#1 @ocean90
7 years ago

In 31577:

Press This: RTL improvements.

  • Load the RTL version of press-this-editor.css.
  • Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.

@ocean90
7 years ago

#2 @ocean90
7 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31579:

Build: Let RTLCSS handle swapping the codes for right/left arrows from Dashicons.

Exclude wp-includes/css/dashicons.css from core task since we don't want/need a RTL version of it.

fixes #31478.

Note: See TracTickets for help on using tickets.