WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31482 closed defect (bug) (fixed)

"Quick Edit" in Comments table row action breaks on small screens

Reported by: kraftbj Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Comments Keywords: make-flow has-patch commit
Focuses: ui, accessibility, administration Cc:

Description

The text in class-wp-comments-list-table.php for the "Quick Edit" row action does not contain a   which can result in a line break mid-link on smaller viewports.

The other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action, so this would bring consistency.

Attachments (3)

31482.diff (923 bytes) - added by kraftbj 6 years ago.
Adds non-breaking space
31482_before.png (170.7 KB) - added by DrewAPicture 6 years ago.
Before
31482_after.png (156.2 KB) - added by DrewAPicture 6 years ago.
After

Download all attachments as: .zip

Change History (10)

@kraftbj
6 years ago

Adds non-breaking space

#1 @rachelbaker
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

Seems reasonable to me. Let's fix it.

Last edited 6 years ago by rachelbaker (previous) (diff)

#2 @SergeyBiryukov
6 years ago

  • Focuses accessibility added

There's also a "Quick Edit" title attribute which duplicates the link text.

Seems like we should either remove it (like in class-wp-terms-list-table.php), or change to "Edit this item inline" (like in class-wp-posts-list-table.php).

What would be better for accessibility?

@DrewAPicture
6 years ago

Before

@DrewAPicture
6 years ago

After

#3 @DrewAPicture
6 years ago

  • Keywords make-flow commit added

Based on 31482_before.png and 31482_after.png, looks like the patch fixes the problem.

@SergeyBiryukov: Do you think adding a translator comment would be beneficial to explain why the non-breaking space is in there?

#4 @DrewAPicture
6 years ago

There's also a "Quick Edit" title attribute which duplicates the link text.

Seems like we should either remove it (like in class-wp-terms-list-table.php), or change to "Edit this item inline" (like in class-wp-posts-list-table.php).

What would be better for accessibility?

@joedolson: What do you think? Either way, it should probably happen in a new ticket.

#5 @joedolson
6 years ago

I think I'd recommend removal. I don't think it really is of any benefit; and while Quick Edit doesn't explicitly say that it'll be inline editing, I think that's a reasonable expectation for users to learn.

#6 @ocean90
6 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

#7 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 31889:

Comments List: Don't let "Quick Edit" break on smaller screens.

Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.

props kraftbj.
fixes #31482.

Note: See TracTickets for help on using tickets.