Opened 10 years ago
Closed 10 years ago
#31482 closed defect (bug) (fixed)
"Quick Edit" in Comments table row action breaks on small screens
Reported by: | kraftbj | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Comments | Keywords: | make-flow has-patch commit |
Focuses: | ui, accessibility, administration | Cc: |
Description
The text in class-wp-comments-list-table.php for the "Quick Edit" row action does not contain a
which can result in a line break mid-link on smaller viewports.
The other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action, so this would bring consistency.
Attachments (3)
Change History (10)
#1
@
10 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.2
#2
@
10 years ago
- Focuses accessibility added
There's also a "Quick Edit" title attribute which duplicates the link text.
Seems like we should either remove it (like in class-wp-terms-list-table.php), or change to "Edit this item inline" (like in class-wp-posts-list-table.php).
What would be better for accessibility?
#3
@
10 years ago
- Keywords make-flow commit added
Based on 31482_before.png and 31482_after.png, looks like the patch fixes the problem.
@SergeyBiryukov: Do you think adding a translator comment would be beneficial to explain why the non-breaking space is in there?
#4
@
10 years ago
There's also a "Quick Edit" title attribute which duplicates the link text.
Seems like we should either remove it (like in class-wp-terms-list-table.php), or change to "Edit this item inline" (like in class-wp-posts-list-table.php).
What would be better for accessibility?
@joedolson: What do you think? Either way, it should probably happen in a new ticket.
Adds non-breaking space