Make WordPress Core

Changes between Version 3 and Version 4 of Ticket #31484


Ignore:
Timestamp:
03/02/2015 12:47:45 AM (10 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31484

    • Property Summary changed from Widgets appearing in Customizer preview during a theme preview may not correspond to controls in Widgets panel to Widgets in Customizer during theme preview fail to preview widgets with prior sidebars_widgets theme mod and fail to apply upon activation
  • Ticket #31484 – Description

    v3 v4  
    22
    33The problem was introduced in WordPress 4.1, specifically in r29905 for #29983, since we're no longer posting all of the settings from the Customizer pane to the preview for performance reasons: only the changed (dirty) settings get POSTed to the Preview when it is loaded.
     4
     5Additionally, when attempting to activate the previous theme that had a cached widgets configuration in the `sidebars_widgets` theme mod, this prior configuration is not getting restored when activating the previously-active theme: the sidebar configuration from the current theme is overwriting the previous theme's configuration. I believe this is due to the `old_sidebars_widgets_data` not being marked as dirty, and so it is not being submitted when saving the settings.
    46
    57Steps to reproduce:
     
    13157. Live-preview the Twenty Thirteen theme either via the Themes admin page, or via the new Customizer theme previewer
    14168. Open the Widgets panel and note that the widgets listed are correctly those for Twenty Thirteen, but notice in the Preview that the widgets from Twenty Fourteen are unexpectedly showing.
     179. Press *Save & Activate* when redirected to the frontend with the Twenty Thirteen theme active, notice that the Twenty Fourteen widgets are incorrectly shown.
     18
     19For previous issues related to widgets in the Customizer being lost during a theme switch, see #27897.