WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#31485 closed enhancement (fixed)

Tags meta box: consider removing taghint

Reported by: afercia Owned by: welcher
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Taxonomy Keywords: good-first-bug has-patch
Focuses: ui, javascript Cc:

Description

Noticed today on Slack with @michaelarestad and @azaozz, looks like taghint was used in 3.0 (and maybe later, see screenshot) like a "fake placeholder" for the new tag input field but it doesn't work anymore (HTML is changed, always hidden with CSS) and maybe no more needed. Still takes some bytes of JavaScript and CSS though. Worth considering some cleaning?
See also Press This.

https://cldup.com/-ggqKEMxKV.png

Attachments (3)

31485.diff (1.9 KB) - added by welcher 2 years ago.
Removes the taghint div and adjust css margin accordingly
31485.2.diff (6.0 KB) - added by welcher 2 years ago.
Updated patch to remove additional css/js references
31485.3.diff (3.4 KB) - added by welcher 2 years ago.
Removed unintended changes in patch

Download all attachments as: .zip

Change History (7)

#1 @helen
2 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 4.2

I wondered to myself if using an HTML placeholder would make sense here, but I think with that multi-purpose input (single and multiple entry) and extra helper text below, it's better without the visual noise. Nobody seems to have complained previously, anyway :)

@welcher
2 years ago

Removes the taghint div and adjust css margin accordingly

#2 @welcher
2 years ago

  • Keywords has-patch added; needs-patch removed

@welcher
2 years ago

Updated patch to remove additional css/js references

#3 @DrewAPicture
2 years ago

  • Owner set to welcher
  • Status changed from new to assigned

@welcher
2 years ago

Removed unintended changes in patch

#4 @helen
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31607:

Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.

It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.

Note: See TracTickets for help on using tickets.