WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31488 closed enhancement (fixed)

Update grunt-contrib-jshint to v0.11.0

Reported by: netweb Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: javascript Cc:

Description

Upstream changes:

Patch includes adding JSON to globals ignore in .jshintrc which avoids the errors below.


Updating to v0.11.0 results in the following Core errors during grunt jshint:core

   src/wp-admin/js/customize-controls.js
   2348 |                    customized: JSON.stringify( dirtyCustomized ),
                                         ^ 'JSON' is not defined.
   src/wp-admin/js/customize-widgets.js
   1025 |                data += '&' + $.param( { 'sanitized_widget_setting': JSON.stringify( instanceOverride ) } );
                                                                              ^ 'JSON' is not defined.
   src/wp-admin/js/image-edit.js
    114 |            history = JSON.parse(history);
                               ^ 'JSON' is not defined.
    151 |            return JSON.stringify(op);
                            ^ 'JSON' is not defined.
    274 |            var ret = JSON.parse(r);
                               ^ 'JSON' is not defined.
    410 |        $('#imgedit-selection-' + postid).val( JSON.stringify(sel) );
                                                        ^ 'JSON' is not defined.
    442 |            history = ( h !== '' ) ? JSON.parse(h) : [],
                                              ^ 'JSON' is not defined.
    456 |        history = ( elem.val() !== '' ) ? JSON.parse( elem.val() ) : [],
                                                   ^ 'JSON' is not defined.
    467 |        elem.val( JSON.stringify(history) );
                           ^ 'JSON' is not defined.
    500 |        sel = JSON.parse(sel);
                       ^ 'JSON' is not defined.
    519 |            history = ( elem.val() !== '' ) ? JSON.parse( elem.val() ) : [];
                                                       ^ 'JSON' is not defined.
   src/wp-includes/js/autosave.js
    124 |                        stored_obj = JSON.parse( stored_obj );
                                              ^ 'JSON' is not defined.
    145 |                    sessionStorage.setItem( key, JSON.stringify( stored_obj ) );
                                                          ^ 'JSON' is not defined.
   src/wp-includes/js/customize-base.js
    578 |            message = JSON.parse( event.data );
                               ^ 'JSON' is not defined.
    603 |            this.targetWindow().postMessage( JSON.stringify( message ), this.origin() );
                                                      ^ 'JSON' is not defined.
   src/wp-includes/js/plupload/wp-plupload.js
    260 |                response = JSON.parse( response.response );
                                    ^ 'JSON' is not defined.

>> 16 errors in 78 files
Warning: Task "jshint:core" failed. Use --force to continue.

Attachments (1)

31488.diff (745 bytes) - added by netweb 6 years ago.

Download all attachments as: .zip

Change History (3)

@netweb
6 years ago

#1 @netweb
6 years ago

  • Keywords has-patch added

#2 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31649:

Update grunt-contrib-jshint to 0.11.0

Props netweb.
Fixes #31488.

Note: See TracTickets for help on using tickets.