WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#31492 closed defect (bug) (fixed)

wp-admin/post.php > sendback URL generated through string concatenation

Reported by: podpirate Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Posts, Post Types Keywords:
Focuses: administration Cc:

Description

This will result in invalid redirect URLs (containing two ?) when admin_url filter is applied before.
Patch uses add_query_arg() rather than string concatenation.

Attachments (1)

fix-sendback-var.diff (541 bytes) - added by podpirate 3 years ago.
use add_query_argfor sendback URL

Download all attachments as: .zip

Change History (3)

@podpirate
3 years ago

use add_query_argfor sendback URL

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.2

#2 @wonderboymusic
3 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31633:

When adding post_type to $sendback in wp-admin/post.php, use add_query_arg() instead of string concatenation.

Props podpirate.
Fixes #31492.

Note: See TracTickets for help on using tickets.