Changes between Initial Version and Version 1 of Ticket #31495, comment 4
- Timestamp:
- 03/01/2015 06:49:31 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #31495, comment 4
initial v1 1 1 Replying to [comment:1 DrewAPicture]: 2 2 > * **wp-activate.php**: The use of `network_site_url()`. I think that needs to be left alone because it's specifically for the multisite/network URL use-case. If it isn't multisite, it'll fall back to `site_url()` anyway. 3 As far as I can tell, `network_site_url()` is used only for "lost password" and "reset password". I think `network_site_url('wp-login.php', 'login')` does not make sense, as it is not used anywhere else in core and should be replaced by `esc_url( wp_login_url() )`. At least, I think it should be discussed. 3 As far as I can tell, `network_site_url()` is used only for "lost password" and "reset password". Is there any reason we should keep using `network_site_url('wp-login.php', 'login')` here for the login address? As it is not used anywhere else in core, it should be replaced by `esc_url( wp_login_url() )` imho. At least, it should be discussed. 4 5 4 6 > * **wp-includes/ms-functions.php**: email template string 5 > * **wp-includes/schema.php**: email template 6 May I suggest something simple? A bit hacky, but retro-compat'. 7 > * **wp-admin/includes/schema.php**: email template 8 I agree for '''schema.php''', we should leave it as it is now. 9 May I suggest something simple for '''ms-functions.php'''? A bit hacky, but back-compat'. 7 10 {{{ 8 11 switch_to_blog( $blog_id ); … … 13 16 }}} 14 17 18 15 19 > Some of those have been in core since we switched from using direct file links more than four years ago. 16 20 Yes, sorry for the "Version 4.1.1" x)