Trim non-breaking spaces from URLs

[pento]

If a link to a WordPress site has a non-breaking space on the end of it, WordPress will give a 404, instead of showing the page. Refreshing the page (allowing the browser to trim the space) causes the page to load correctly.

[pento]

nbsp.html​ is a sample test case.

31499.diff​ trims any non-breaking spaces from the end of the URL, it doesn't trim them if there's a trailing / - the assumption is that they were incorrectly included in a copy/paste, for example, if they're at the very end of the URL. If there's a trailing /, we assume it's intentional.

[valendesigns]

Wouldn't preg_replace do a search and replace for all non-breaking spaces, not just trim the last one?

[pento]

Replying to valendesigns:

Wouldn't preg_replace do a search and replace for all non-breaking spaces, not just trim the last one?

The $ at the end of the regex means it'll only match non-breaking spaces at the end of the string.

[valendesigns]

Ah, thanks for the explanation. Cheers!

[pento]

In 31838:

If the URL being visited has non-breaking spaces at the end of it, they were probably inserted by an errant URL copy/paste. Instead of showing a 404 for no obvious reason, let's just trim them.

Fixes #31499