Replace embed URL with error message if oEmbed provider returns an error

[mbootsman]

If a youtube url in a post does not work when video is removed, or any other error occurs, the url of the video is shown. I tink it's better for UX to show an error message.

[istein]

Hey, I think that this is a good idea too. I'll try some things over the next few days and post what I come up with for people to discuss.

[mbootsman]

Replying to istein:

Hey, I think that this is a good idea too. I'll try some things over the next few days and post what I come up with for people to discuss.

Cool! Maybe obsolete, but please use a filter for this, so ppl can change the message if they want to.

[iseulde]

Do you mean in the editor, or the front-end? Maybe related: #29841. Links won't be converted to anything unless there's something from the provider to show. IMO it's up to them to show a message. If they do, we will show it.

[mbootsman]

Replying to iseulde:

Do you mean in the editor, or the front-end? Maybe related: #29841. Links won't be converted to anything unless there's something from the provider to show. IMO it's up to them to show a message. If they do, we will show it.

I mean in the front-end. In the editor a embed image is shown. I think that if you try to embed something that does not exist, WordPress should tell that something went wrong, and have this message be filterable.

[jesin]

Replying to mbootsman:

I mean in the front-end. In the editor a embed image is shown. I think that if you try to embed something that does not exist, WordPress should tell that something went wrong, and have this message be filterable.

I believe the embed_maybe_make_link can be used for this. It is present in tags/4.1/src/wp-includes/class-wp-embed.php#L332​.

[iseulde]

In the editor a embed image is shown.

Really? Can you give us an example video?

[mbootsman]

Replying to iseulde:

In the editor a embed image is shown.

Really? Can you give us an example video?

My bad, at first the embed image is hown, but when an invalid link is used, the url is shown. When this url is changed to a valid video, the video is shown.

[mbootsman]

Replying to jesin:

Replying to mbootsman:

I mean in the front-end. In the editor a embed image is shown. I think that if you try to embed something that does not exist, WordPress should tell that something went wrong, and have this message be filterable.

I believe the embed_maybe_make_link can be used for this. It is present in tags/4.1/src/wp-includes/class-wp-embed.php#L332​.

Hmm, I missed that filter, seems usable! Thanks.

[iseulde]

Can you give us an example video, please?

[jesin]

Replying to iseulde:

Can you give us an example video, please?

Take any video URL and remove a character from it.

Valid video - ​https://www.youtube.com/watch?v=2mBG4vlhcCc

Video doesn't exist - ​https://www.youtube.com/watch?v=2mBG4vlhcC

[GaVrA]

I added 31502.diff​ patch that does the following:

1. checks response.success and if that is true it shows embed html in response.data.body
2. if response.success is false it runs this.renderFail()
3. inside this.renderFail() I check for response.data.type and if it is equal to not-embeddable it shows an error and returns.

[GaVrA]

I'm not sure if this is enough, maybe input should be cleared?

$('#embed-url-field' ).val('');?

Also if embed fails, you can still press Insert into page button. I'm not sure how would you go about disabling that since I'm not all that familiar with backbone.

[jesin]

Patch 31502.diff​ only checks when adding an embed URL. OP's problem is what happens when an existing video is removed by the video hosting service.

[deremohan]

Replying to jesin:

Patch 31502.diff​ only checks when adding an embed URL. OP's problem is what happens when an existing video is removed by the video hosting service.

Hi Jesin,
As looking ajax call inside ajax-actions.php file at line 2818:

if ( $url && ! $parsed ) {
 $parsed = $wp_embed->run_shortcode( $shortcode );
}

If existing video is removed from hosting, then video url is not get parsed which leads to 'not-embeddable' type error. i mean this case should be handle by WP_Embed class.

Also please have a look for patch which also handles "not-ssl" response from ajax.

[swissspidy]

See also #24712

[DrewAPicture]

Assigning to mark the good-first-bug as "claimed".

[desrosj]

How a previously embedded video that has since been deleted (though very recently) looks on load. It's possible the thumbnail is also eventually deleted.

[desrosj]

Clicking play on a previously embedded video that has since been deleted

[desrosj]

Clicking play on a previously embedded video that has since been moved private

[desrosj]

I have not been able to reproduce the originally reported issue. I have documented the current behavior with screenshots. This is the behavior that happens so long as the cached embed response (stored in post meta) is not deleted. If that occurs (which does not happen in default WordPress), the URL will be displayed instead.

I am going to close this out as it seems to be working as it should.