Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 15 years ago

#3151 closed enhancement (fixed)

Change name of unregister_globals() function

Reported by: trevorturk's profile trevorturk Owned by:
Milestone: 2.1 Priority: normal
Severity: trivial Version: 2.0.4
Component: General Keywords:
Focuses: Cc:

Description

Please consider changing the name of the unregister_globals() function found in wp-settings.php. This function name conflicts with some other programs, and I don't see any downside to changing it. It will make it easier to integrate with other apps without modifying the core. Thanks!

Attachments (1)

3151.diff (579 bytes) - added by westi 18 years ago.
Rename unregister_GLOBALS

Download all attachments as: .zip

Change History (8)

#1 @foolswisdom
18 years ago

  • Milestone changed from 2.1 to 2.2

Hi Trevorturk,

How was this a problem for you?

What other programs are you referring to? A search suggests maybe PunBB and Lyceum have such a function, though I can imagine it being a common function name.

#2 @westi
18 years ago

So that would only be PunBB then as Lyceum is a WordPress multiblog derivative.

#3 @trevorturk
18 years ago

I hit it when working with PunBB. I thought there were more apps that conflicted, but I guess not. PunBB made the change already in svn (http://dev.punbb.org/changeset/576), so perhaps this ticket should be closed?

#4 @westi
18 years ago

  • Milestone changed from 2.2 to 2.1

Actually it may be prudent here to rename it wp_unregister_globals now so that it can't become an issue in the future with any other integration.

I suspect it will become a well used function name accross php webapps as they strive for good security.

I think this small change is a good candidate for 2.1

@westi
18 years ago

Rename unregister_GLOBALS

#5 @trevorturk
18 years ago

I agree this is a safe move. Thanks for posting the patch, westi.

#6 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4203]) Prefix unregister_GLOBALS to avoid name collisions. Props westi. fixes #3151

#7 @hakre
15 years ago

Related: #12519

Note: See TracTickets for help on using tickets.