WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 months ago

#31511 closed defect (bug) (fixed)

Update jQueryColor Library to latest version

Reported by: lovememore Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch needs-testing
Focuses: javascript Cc:

Description

Update jQueryColor Library (wp-includes/js/jquery/jquery.color.min.js) to latest version 2.1.2

Links:
https://github.com/jquery/jquery-color
http://code.jquery.com/color/jquery.color-2.1.2.min.js

Attachments (3)

31511.diff (16.7 KB) - added by desrosj 3 years ago.
Update jQuery Color to 2.1.2.
31511.2.diff (1.3 KB) - added by Hareesh Pillai 6 months ago.
Changes to package.json and package-lock.json file
31511.3.diff (20.7 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (12)

#1 @DrewAPicture
5 years ago

  • Component changed from General to External Libraries

#2 @DrewAPicture
5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

@desrosj
3 years ago

Update jQuery Color to 2.1.2.

#3 @desrosj
3 years ago

Updated the library in my last patch. However, 2.1.2 was released in 2013. It looks like the wp-lists script has this library as a dependency. I would be curious to see how many plugins utilize this script, and if there is another library that is better maintained we could look at replacing this one with.

#4 @desrosj
3 years ago

  • Keywords has-patch added

@Hareesh Pillai
6 months ago

Changes to package.json and package-lock.json file

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


5 months ago

#6 @mikeschroder
5 months ago

  • Focuses javascript added
  • Keywords needs-testing added

#7 @mikeschroder
5 months ago

@desrosj Does this look like something that would work for 5.3?

#8 @SergeyBiryukov
5 months ago

  • Milestone changed from Future Release to 5.3

Looking at 31511.diff, the currently bundled script includes a minified version of jquery.color.svg-names.js, which is no longer the case with the patch.

31511.3.diff is a refresh with jquery.color.plus-names-2.1.2.min.js.

#9 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46095:

External Libraries: Update jQuery Color plugin to 2.1.2.

Props desrosj, hareesh-pillai, lovememore.
Fixes #31511.

Note: See TracTickets for help on using tickets.