WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 7 of Ticket #31517


Ignore:
Timestamp:
10/08/2016 03:28:41 PM (10 years ago)
Author:
westonruter
Comment:

This has been implemented in the patch for #30937.

When a link is not previewable it will get a cursor:not-allowed style and wp.a11y.speak() will be called to accessibly notify that it cannot be live previewed. Likewise, when attempting to submit a form that is not live-previewable (if it uses a POST method or has an action that points off of the site) there will be be the same cursor:not-allowed style added to the form and all of its inputs with a similar non-previewable message output via wp.a11y.speak().

Please test: grunt patch:https://github.com/xwp/wordpress-develop/pull/161

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31517

    • Property Milestone Awaiting Review → 4.7
    • Property Keywords has-patch needs-testing added
    • Property Owner set to westonruter
    • Property Status new → accepted

  • Ticket #31517 – Description

    initial v7  
    44Clicking on an external link from the live preview pane fails silently. To help avoid confusion, we could display a notice to alert when someone clicks on an external link in a live preview:
    55
    6 > ⚠ You can only preview internal, front-end links in the customizer.
     6> You can only preview internal, front-end links in the customizer.
    77
    88Here is a past description of how a customizer notice could work from @westonruter: https://core.trac.wordpress.org/ticket/30677#comment:7 (different use case, but the part about how the alert might work is relevant)