WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#31519 closed defect (bug) (wontfix)

Classes that extend WP_List_Table no longer return undefined variables

Reported by: johnjamesjacoby Owned by: wonderboymusic
Milestone: Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: 2nd-opinion dev-feedback
Focuses: administration Cc:

Description

Magic methods in WP_List_Table previously returned any requested variable, allowing subclasses to add their own without needing to define them in the subclass.

Related to changes in [WP31146] & #WP30891, any classes which extend WP_List_Table that do not define their variables will return null where they previously returned anticipated results.

Change History (5)

#1 @johnjamesjacoby
6 years ago

Related from BuddyPress: https://buddypress.trac.wordpress.org/ticket/6277

I suspect this is a case of BuddyPress doing-it-wrong-enough where this ticket is a wontfix for WordPress core.

#2 @johnjamesjacoby
6 years ago

BuddyPress will be fixed for versions 2.2.2 and higher.

bbPress is unaffected.

#3 @johnjamesjacoby
6 years ago

  • Focuses administration added

Adding the "admin" focus so this ticket can be triaged by the appropriate team.

#4 @DrewAPicture
6 years ago

  • Keywords dev-feedback added
  • Owner set to wonderboymusic
  • Status changed from new to assigned

@wonderboymusic: Mind taking a look at this?

#5 @wonderboymusic
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Yeah, the magic-everything approach in 4.0 was meant to be temporary, and I should have taken a 2nd pass sooner than I did to clean those things up.

In January (of 2015), I audited all of those instances and either 1) switched/cleaned up the visibility of class properties or 2) specified "compat" fields/methods, example: [31151]

I apologize for the turbulence, but all that magic was an unintended side effect.

Note: See TracTickets for help on using tickets.