WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#3152 closed defect (bug) (fixed)

WP_User->ID, not WP_User->id

Reported by: alexkingorg Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: General Keywords: has-patch
Focuses: Cc:

Description

Fixed several references to WP_User->ID, the id is a lowercase var in this class.

Attachments (2)

patch.diff (853 bytes) - added by alexkingorg 8 years ago.
patch attached
3152.diff (4.9 KB) - added by Nazgul 8 years ago.

Download all attachments as: .zip

Change History (7)

alexkingorg8 years ago

patch attached

comment:1 ryan8 years ago

ID is set when we pull the users table data into the WP_User class. I'd like to stick with uppercase ID since it is more widely used due to it being in the table. How about adding var $ID = 0 to the WP_User class and putting a comment next to $id noting that it is deprecated?

comment:2 foolswisdom8 years ago

  • Milestone set to 2.1

Nazgul8 years ago

comment:3 Nazgul8 years ago

  • Keywords has-patch added
  • Summary changed from WP_User->id, not WP_User->ID to WP_User->ID, not WP_User->id

Created a patch, based on Ryan's suggestion.

comment:4 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4504]) ID instead of id. Props Nazgul. fixes #3152

comment:5 ryan7 years ago

(In [4505]) ID instead of id. Props Nazgul. fixes #3152

Note: See TracTickets for help on using tickets.